Removes Commons Lang 2 usage#124
Merged
malice00 merged 3 commits intojenkinsci:masterfrom Feb 10, 2026
Merged
Conversation
alecharp
commented
Feb 3, 2026
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>parameterized-scheduler</artifactId> | ||
| <version>374.v531b_4f4d99b_3</version> |
Member
Author
There was a problem hiding this comment.
Moved it to <dependencyManagement/>
Member
Author
There was a problem hiding this comment.
The plugins was added in BOM 2 years ago. I generally find it a better approach to set the version in the dependencyManagement.
alecharp
commented
Feb 3, 2026
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>extended-timer-trigger</artifactId> | ||
| <version>48.vf99b_c63a_685b_</version> |
Member
Author
There was a problem hiding this comment.
Moved it to <dependencyManagement/>
alecharp
commented
Feb 3, 2026
Member
Author
|
This should be labelled |
jonesbusy
reviewed
Feb 8, 2026
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <dependency> |
Member
Author
There was a problem hiding this comment.
yes but not in the bom version used by the plugin. I didn't want to enforce a core and bom bump for this pull request.
Contributor
|
Thanks. Labelled as requested and will release in a couple of days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes usage of Commons Lang 2 from the plugin.
Follow-up of jenkinsci/jenkins#26105 and jenkinsci/bom#6234
Testing done
After fake releasing the parameterized-scheduler with jenkinsci/parameterized-scheduler-plugin#297 content (
mvn -Dset.changelist -DskipTests clean install), I could runmvn verify -Djenkins.version=2.549-rc37946.27a_9c5162f85with success.I could also validate the BOM when both plugins are updated.
Submitter checklist